Not prompting to create passkey? #447
Labels
No labels
bug
chore
documentation
enhancement
help
in-progress
question
ready-for-release
released
translation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
adam/gate#447
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Despite having a device which definitely supports passkeys (iPhone 17 Pro), after logging in to a test account with a password I was not prompted to create a passkey, as shown in the docs:
However, I do already have passkeys from other accounts in my phone.
Is this question supposed to show up under different circumstances than I assumed, or does it somehow fail to show unless I have zero passkeys saved?
Ah, I see now:
github.com/voidauth/voidauth@588300f1f0/frontend/src/app/services/passkey.service.ts (L163-L169)I guess my suggestion would be for non-privileged users to also get prompted for passkeys on account creation, as just a standard feature.
This is based on my understanding of a typical user flow:
By prompting them to create a passkey (on supported devices) right after they create an account with a password, for golden-path cases where their device supports passkeys, they get all future use cases handled immediately.
In this case
user.isPrivilegedindicates that the session of the signed in user has the ability to perform sensitive actions like changing profile settings and setting a passkey. Thank you for opening a PR related to this issue, I will take a look at it when I get the chanceAh, my bad, thanks! I'll put that check back in the PR.
Done! Strange, though, that the check didn't seem to fire initially (hence this issue).