redirection after approval #442

Open
opened 2026-05-23 10:07:41 -05:00 by konstkarapan · 5 comments
konstkarapan commented 2026-05-23 10:07:41 -05:00 (Migrated from github.com)

Describe the bug:

I'm not really sure if this is a bug, but when a new user signs up,he gets a waiting for approval screen. The thing is that after being approved and he clicks login, he doesn't get redirected to DEFAULT_REDIRECT, rather to the voidauth domain

To Reproduce:

Try to sign in as an un approved user
You get the "Approval Required" screen
Admin aprooves you
You click login
You log in with your credentials
You get redirected to your voidauth domain instead of DEFAULT_REDIRECT

Expected behavior:

I suppose you should be redirected to DEFAULT_REDIRECT

Database Driver:

Screenshots:

Additional context:

### Describe the bug: <!-- A clear description of the bug --> I'm not really sure if this is a bug, but when a new user signs up,he gets a waiting for approval screen. The thing is that after being approved and he clicks login, he doesn't get redirected to DEFAULT_REDIRECT, rather to the voidauth domain ### To Reproduce: <!-- How to get the bug to happen --> Try to sign in as an un approved user You get the "Approval Required" screen Admin aprooves you You click login You log in with your credentials You get redirected to your voidauth domain instead of DEFAULT_REDIRECT ### Expected behavior: <!-- What should be happening that isn't, or is happening that shouldn't --> I suppose you should be redirected to DEFAULT_REDIRECT ### Database Driver: <!-- If DB_ADAPTER environment variable is set, what is it set to? --> ### Screenshots: <!-- If an issue visible from the web UI, please attach a screenshot --> ### Additional context: <!-- Any additional information that you think might be important -->
notquitenothing commented 2026-06-04 23:29:04 -05:00 (Migrated from github.com)

This should be fixed in the latest release v1.13.0

This should be fixed in the latest release [v1.13.0](https://github.com/voidauth/voidauth/releases/tag/v1.13.0)
konstkarapan commented 2026-06-04 23:40:54 -05:00 (Migrated from github.com)

Just checked and I now see another issue. After signing up the user gets a waiting for approval screen only this time there are two buttons. Try again and log in. The thing is that even after the admin approves the user, clicking the buttons without refreshing the page results in 403. In case the user refreshes the page and then clicks any of the buttons he gets redirected to the voidauth domain.
I believe there should be only 1 button which redirects the user to the domain he tried to connect to in the first place.

Just checked and I now see another issue. After signing up the user gets a waiting for approval screen only this time there are two buttons. Try again and log in. The thing is that even after the admin approves the user, clicking the buttons without refreshing the page results in 403. In case the user refreshes the page and then clicks any of the buttons he gets redirected to the voidauth domain. I believe there should be only 1 button which redirects the user to the domain he tried to connect to in the first place.
konstkarapan commented 2026-06-17 07:31:09 -05:00 (Migrated from github.com)

@notquitenothing

@notquitenothing
notquitenothing commented 2026-06-17 08:00:54 -05:00 (Migrated from github.com)

Interesting, I am not able to replicate on my setup. User signs up, redirected to 'approval required' page, 'Try Again' button works (even after refresh) and sends them to requested destination. Two buttons right next to each other may not be the right UX, but there should be some way for a user on the approval required page to try logging in again. I will look at it some more when I get the chance and see if I can find a way to replicate the issue

Interesting, I am not able to replicate on my setup. User signs up, redirected to 'approval required' page, 'Try Again' button works (even after refresh) and sends them to requested destination. Two buttons right next to each other may not be the right UX, but there should be some way for a user on the approval required page to try logging in again. I will look at it some more when I get the chance and see if I can find a way to replicate the issue
konstkarapan commented 2026-06-17 08:02:05 -05:00 (Migrated from github.com)

Ok, thanks!

Ok, thanks!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
adam/gate#442
No description provided.