Less strict URL checking in redirect URLs list #128
Labels
No labels
bug
chore
documentation
enhancement
help
in-progress
question
ready-for-release
released
translation
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
adam/gate#128
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Is your feature request related to a problem? Please describe:
As per Immich docs (https://immich.app/docs/administration/oauth/) a URL in the format
app.immich:///oauth-callbackis required for OAuth in the mobile app. This is currently not possible with VoidAuth as it rejects it with "redirect_uris must only contain web uris".Describe the solution you'd like:
Redirect URLs should allow inclusion of such mobile app URLs to allow SSO on devices as well as on web
To add that this issue also effects all of the available apps for audiobookshelf and means I cannot sign into those whilst using voidauth as my identity provider either.
Looking at how other authentication providers handle this, they appear to just not care and not have strict url checking.
However the docs actually list immich and its app URL https://voidauth.app/#/OIDC-Guides?id=-immich
But I double checked and it's the app URL that causes the issue. Which will be the same for all apps as @elliott-parkinson said.
Not sure if strict redirect url checking is eveb necessary as these URLs are added by the admin and wouldn't be under control by a third party for malicious purposes.
Thanks for opening an issue!
On your VoidAuth OIDC Client page for your client app, can you try selecting
nativefrom theApplication Typedrop-down under the area to add Redirect URLs? If you do not see the drop-down, you may need to update your VoidAuth version using something likedocker compose pull voidauthanddocker compose up -d voidauth.Let me know if that does/doesn't work to fix the issue
Thank you for the reply. Yes that works, and having re-read the doc page I linked I can now see it says "select native". Although this works, the issue I have (but can work around) is that I have my immich hosted in my Tailscale network and thus only have http paths to the instance. I can get around this though
Unfortunately this seems to be a limitation (on purpose, possibly to conform to OIDC spec?) of the OIDC provider library I use in VoidAuth, node-oidc-provider. It seems you can either have insecure protocols with the
webApplication Type, or arbitrary app protocols withnative.A possible user experience improvement in VoidAuth would be detecting app protocol URLs and automatically switching to the
nativeApplication Type if possible.